3.x.x #29
3.x.x #29
Conversation
# Conflicts: # components/Terminal.js # package.json # yarn.lock
# Conflicts: # package.json
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-babel". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-babel is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-babel@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
|
|
||
| .terminal-tab-bar-empty { | ||
| display: inline-block; | ||
| min-width: 25px; |
There was a problem hiding this comment.
Properties should be ordered display, flex, height, min-width
| .terminal-tab-plus { | ||
| display: inline-block; | ||
| color: white; | ||
| border: 1px solid white; |
There was a problem hiding this comment.
Color white should be written in hexadecimal form as #ffffff
Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
|
|
||
| .terminal-tab-plus { | ||
| display: inline-block; | ||
| color: white; |
There was a problem hiding this comment.
Color white should be written in hexadecimal form as #ffffff
Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .terminal-tab-plus { | ||
| display: inline-block; |
There was a problem hiding this comment.
Properties should be ordered border, border-radius, color, cursor, display, font-size, height, line-height, margin-left, margin-top, opacity, text-align, transition, width
| } | ||
| } | ||
|
|
||
| .terminal-tab-plus { |
There was a problem hiding this comment.
Rule set contains (14/10) properties
| display: inline-block; | ||
| vertical-align: top; | ||
| height: 30px; | ||
| background-color: #333; |
There was a problem hiding this comment.
Color literals like #333 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .terminal-tab { | ||
| display: inline-block; |
There was a problem hiding this comment.
Properties should be ordered background-color, border-bottom, box-sizing, cursor, display, height, line-height, overflow, padding-left, padding-right, position, text-align, text-overflow, vertical-align, white-space, width
| margin: 0 auto; | ||
| } | ||
|
|
||
| .terminal-tab { |
There was a problem hiding this comment.
Rule set contains (16/10) properties
| height: 30px; | ||
| max-width: 600px; | ||
| transition: all 0.4s ease-out; | ||
| background: #222; |
There was a problem hiding this comment.
Color literals like #222 should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -0,0 +1,82 @@ | |||
| .terminal-tab-bar { | |||
| height: 30px; | |||
There was a problem hiding this comment.
Properties should be ordered background, display, height, margin, max-width, transition
No description provided.